-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-14807] Create a compatibility module #12580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
compatibility/pom.xml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add an extra line
|
I'd name this something like spark-1.x-compatibility (is dot allowed in the name?) |
project/SparkBuild.scala
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we should move sketch and compatibility out from this list once we release 2.0, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The same goes for sketch and mllibLocal. Can you file a blocker JIRA for 2.0.1 / 2.1 to make sure that we audit this post-release?
|
also this should probably go into sql? |
|
Test build #56572 has finished for PR 12580 at commit
|
dev/sparktestsupport/modules.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to pre-emptively add hive to this list.
|
Broadly, why is this a new and generic module? it seems quite Hive specific. I get that other fairly different compatibility shims could go here later, but those would properly be different modules right? |
|
@srowen I am moving this into sql. |
|
Test build #56578 has started for PR 12580 at commit |
|
@JoshRosen https://issues.apache.org/jira/browse/SPARK-14818 is the jira for updating mima exclusions. |
|
@srowen @rxin @JoshRosen How's this version? |
|
Test build #56580 has finished for PR 12580 at commit
|
sql/hive-1-x-compatibility/pom.xml
Outdated
| <configuration> | ||
| <compilerArgs combine.children="append"> | ||
| <!-- This option is needed to suppress warnings from sun.misc.Unsafe usage --> | ||
| <arg>-XDignore.symbol.file</arg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supressing warnings for sun.misc.unsafe sounds good, but do we need it in the hive compatibility shims project (this does suppress other warnings that we might want to see if we aren't planning on using sun.misc.unsafe here)?
|
Test build #56604 has finished for PR 12580 at commit
|
|
Test build #56606 has started for PR 12580 at commit |
|
Test build #56608 has finished for PR 12580 at commit
|
|
LGTM. We can always change the name later. |
What changes were proposed in this pull request?
This PR creates a compatibility module in sql (called
hive-1-x-compatibility), which will host HiveContext in Spark 2.0 (moving HiveContext to here will be done separately). This module is not included in assembly because only users who still want to access HiveContext need it.How was this patch tested?
I manually tested
sbt/sbt -Phive packageandmvn -Phive package -DskipTests.