Skip to content

Conversation

@gatorsmile
Copy link
Member

What changes were proposed in this pull request?

#12185 contains the original PR I submitted in #10418

However, it misses one of the extended example, a wrong description and a few typos for collection functions. This PR is fix all these issues.

How was this patch tested?

The existing test cases already cover it.

@gatorsmile gatorsmile changed the title [SPARK-12457] Fixed the Typos in Collection Functions [SPARK-12457] Fixed the Wrong Description and Missing Example in Collection Functions Apr 19, 2016
@SparkQA
Copy link

SparkQA commented Apr 19, 2016

Test build #56195 has finished for PR 12492 at commit 67fb4f0.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@ExpressionDescription(
usage = "_FUNC_(array(obj1, obj2,...)) - Sorts the input array in ascending order according to the natural ordering of the array elements.",
extended = " > SELECT _FUNC_(array('b', 'd', 'c', 'a'));\n 'a', 'b', 'c', 'd'")
usage = "_FUNC_(array(array, ascendingOrder)) - Sorts the input array in ascending order according to the natural ordering of the array elements.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh... a bug caused by copy and paste. Let me fix it. Thanks!

@SparkQA
Copy link

SparkQA commented Apr 19, 2016

Test build #56196 has finished for PR 12492 at commit 9238c41.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 19, 2016

Test build #56213 has finished for PR 12492 at commit b2bb9d8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Apr 19, 2016

Thanks - merging in master.

@asfgit asfgit closed this in d9620e7 Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants