Skip to content

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Apr 15, 2016

What changes were proposed in this pull request?

We currently hard code the max number of optimizer/analyzer iterations to 100. This patch makes it configurable. While I'm at it, I also added the SessionCatalog to the optimizer, so we can use information there in optimization.

How was this patch tested?

Updated unit tests to reflect the change.

@SparkQA
Copy link

SparkQA commented Apr 15, 2016

Test build #55975 has finished for PR 12434 at commit 0139855.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • trait CatalystConf
    • abstract class Optimizer(catalog: SessionCatalog, conf: CatalystConf)
    • class SimpleTestOptimizer extends Optimizer(
    • class SparkOptimizer(

@dongjoon-hyun
Copy link
Member

Hi, @rxin.
May I prepare to change my previous PR #12353 about maxCaseBranches according to this PR?

rxin added 2 commits April 15, 2016 18:01
Conflicts:
	sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
	sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizerExtendableSuite.scala
	sql/core/src/main/scala/org/apache/spark/sql/execution/SparkOptimizer.scala
	sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala
@SparkQA
Copy link

SparkQA commented Apr 16, 2016

Test build #55984 has finished for PR 12434 at commit a7fbf87.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor Author

rxin commented Apr 16, 2016

cc @yhuai

@yhuai
Copy link
Contributor

yhuai commented Apr 16, 2016

LGTM. Merging to master!

@asfgit asfgit closed this in f4be094 Apr 16, 2016
lw-lin pushed a commit to lw-lin/spark that referenced this pull request Apr 20, 2016
… Catalyst

## What changes were proposed in this pull request?
We currently hard code the max number of optimizer/analyzer iterations to 100. This patch makes it configurable. While I'm at it, I also added the SessionCatalog to the optimizer, so we can use information there in optimization.

## How was this patch tested?
Updated unit tests to reflect the change.

Author: Reynold Xin <[email protected]>

Closes apache#12434 from rxin/SPARK-14677.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants