Skip to content

Conversation

@joan38
Copy link
Contributor

@joan38 joan38 commented Apr 14, 2016

What changes were proposed in this pull request?

Add @DeveloperApi on PythonUserDefinedType

@SparkQA
Copy link

SparkQA commented Apr 14, 2016

Test build #55838 has finished for PR 12401 at commit ed200fd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

In general @DeveloperApis are only used for public classes. What is the motivation for adding this here?

@asfgit asfgit closed this in a9324a0 Apr 15, 2016
@joan38
Copy link
Contributor Author

joan38 commented Apr 18, 2016

@andrewor14 Sorry I've been confused by the ::DeveloperApi:: in comments.
Should we remove ::DeveloperApi:: from the scaladoc then?

@andrewor14
Copy link
Contributor

Oh now I see why you did that. Yeah it doesn't even make sense to add a ::DeveloperApi:: to something without an annotation. I would remove that comment.

@joan38
Copy link
Contributor Author

joan38 commented Apr 18, 2016

Cheers @andrewor14 for the clarification. I will do a PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants