Skip to content

Conversation

@lw-lin
Copy link
Contributor

@lw-lin lw-lin commented Apr 14, 2016

What changes were proposed in this pull request?

Currently many public abstract methods (in abstract classes as well as traits) don't declare return types explicitly, such as in o.a.s.streaming.dstream.InputDStream:

def start() // should be: def start(): Unit
def stop()  // should be: def stop(): Unit

These methods exist in core, sql, streaming; this PR fixes them.

How was this patch tested?

N/A

Which piece of scala style rule led to the changes?

the rule was added separately in #12396

@srowen
Copy link
Member

srowen commented Apr 14, 2016

LGTM. It's good practice to make method return types explicit, especially if they're to be implemented in other classes. This should not change any behavior since it just makes the implicit "Unit" return type explicit.

@SparkQA
Copy link

SparkQA commented Apr 14, 2016

Test build #55809 has finished for PR 12389 at commit d3d83b0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Apr 14, 2016

Merging in master. Thanks.

@asfgit asfgit closed this in 3e27940 Apr 14, 2016
@lw-lin
Copy link
Contributor Author

lw-lin commented Apr 15, 2016

@srowen @rxin thank you for the review & merging! :-)

@lw-lin lw-lin deleted the public-abstract-methods branch April 15, 2016 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants