-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-14572] [Doc] Update config docs to allow -Xms in extraJavaOptions #12333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I don't think this is useful to state, per JIRA. |
|
@srowen Even if we don't specify explicitly that -Xms can be set, we will need to update the doc which currently states that it is illegal to specify heap memory settings. |
|
So I agree its not explicitly necessary to state Xms here, the only reason I think to mention it is the behavior is different from 1.X to 2.X, but there will be many other things different to so not a big deal to me on that. I do think some of the other text he added here is useful though and makes the descriptions across driver/executor/am more consistent. @srowen What do you think about just removing the sentence "However, specifying an initial heap
|
|
@dhruve you should put the jira name int he pr description. Please see guidelines at: https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark#ContributingtoSpark-PullRequest |
|
@tgravescs I agree with that suggestion |
|
I have updated the docs and removed the explicit mentions of Xms being allowed. |
|
LGTM |
|
Jenkins, test this please |
|
+1, just doc changes so shouldn't really need jenkins, but kicked anyway. |
|
Test build #55822 has finished for PR 12333 at commit
|
What changes were proposed in this pull request?
The configuration docs are updated to reflect the changes introduced with SPARK-12384. This allows the user to specify initial heap memory settings through the extraJavaOptions for executor, driver and am.
How was this patch tested?
The changes are tested in SPARK-12384. This is just documenting the changes made.