Skip to content

[MINOR][SQL] Re-enable explode() and json_tuple() testcases in ExpressionToSQLSuite #12329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 1 commit into from
Closed

[MINOR][SQL] Re-enable explode() and json_tuple() testcases in ExpressionToSQLSuite #12329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/ExpressionToSQLSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,7 @@ class ExpressionToSQLSuite extends SQLBuilderTest with SQLTestUtils {
checkSqlGeneration("SELECT abs(15), abs(-15)")
checkSqlGeneration("SELECT array(1,2,3)")
checkSqlGeneration("SELECT coalesce(null, 1, 2)")
// wait for resolution of JIRA SPARK-12719 SQL Generation for Generators
// checkSqlGeneration("SELECT explode(array(1,2,3))")
checkSqlGeneration("SELECT explode(array(1,2,3))")
checkSqlGeneration("SELECT greatest(1,null,3)")
checkSqlGeneration("SELECT if(1==2, 'yes', 'no')")
checkSqlGeneration("SELECT isnan(15), isnan('invalid')")
Expand Down Expand Up @@ -200,8 +199,7 @@ class ExpressionToSQLSuite extends SQLBuilderTest with SQLTestUtils {
checkSqlGeneration("SELECT locate('is', 'This is a test', 3)")
checkSqlGeneration("SELECT lpad('SparkSql', 16, 'Learning')")
checkSqlGeneration("SELECT ltrim(' SparkSql ')")
// wait for resolution of JIRA SPARK-12719 SQL Generation for Generators
// checkSqlGeneration("SELECT json_tuple('{\"f1\": \"value1\", \"f2\": \"value2\"}','f1')")
checkSqlGeneration("SELECT json_tuple('{\"f1\": \"value1\", \"f2\": \"value2\"}','f1')")
checkSqlGeneration("SELECT printf('aa%d%s', 123, 'cc')")
checkSqlGeneration("SELECT regexp_extract('100-200', '(\\d+)-(\\d+)', 1)")
checkSqlGeneration("SELECT regexp_replace('100-200', '(\\d+)', 'num')")
Expand Down