Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

It looks several recent commits for datasources (maybe while removing old HadoopFsRelation interface) missed removing some unused imports.

This PR removes some unused imports in datasources.

How was this patch tested?

sbt scalastyle and some unit tests for them.

@HyukjinKwon
Copy link
Member Author

I also noticed that SqlNewHadoopRDD is not used anymore. Just to double check, this would not mean necessarily this has to be removed?

@HyukjinKwon HyukjinKwon changed the title [MINOR][SQL][DOCS] Remove some unused imports in datasources. [MINOR][SQL] Remove some unused imports in datasources. Apr 12, 2016
@SparkQA
Copy link

SparkQA commented Apr 12, 2016

Test build #55601 has finished for PR 12326 at commit 4e58cdd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

@cloud-fan Could you please take a look?

@cloud-fan
Copy link
Contributor

LGTM, cc @liancheng @yhuai should we remove SqlNewHadoopRDD?

@cloud-fan
Copy link
Contributor

Thanks ! merging to master!

@cloud-fan
Copy link
Contributor

@HyukjinKwon could you open another PR to remove the SqlNewHadoopRDD? I think it's not needed anymore.

@asfgit asfgit closed this in 587cd55 Apr 13, 2016
@HyukjinKwon
Copy link
Member Author

@cloud-fan Sure. Let me open a PR. Thanks.

asfgit pushed a commit that referenced this pull request Apr 14, 2016
…ed imports

## What changes were proposed in this pull request?

Old `HadoopFsRelation` API includes `buildInternalScan()` which uses `SqlNewHadoopRDD` in `ParquetRelation`.
Because now the old API is removed, `SqlNewHadoopRDD` is not used anymore.

So, this PR removes `SqlNewHadoopRDD` and several unused imports.

This was discussed in #12326.

## How was this patch tested?

Several related existing unit tests and `sbt scalastyle`.

Author: hyukjinkwon <[email protected]>

Closes #12354 from HyukjinKwon/SPARK-14596.
@HyukjinKwon HyukjinKwon deleted the minor-imports branch January 2, 2018 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants