[SPARK-14544] [SQL] improve performance of SQL UI tab #12311
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @zsxwing |
| <script> | ||
| function clickDetail(details) {{ | ||
| details.parentNode.querySelector('.stage-details').classList.toggle('collapsed') | ||
| }} |
Contributor
There was a problem hiding this comment.
do you need double }} here?
Contributor
Author
There was a problem hiding this comment.
I don't know, copied from ExecutionPage
Member
There was a problem hiding this comment.
It's necessary to escape { in xml.
Member
There was a problem hiding this comment.
(Necessary when writing XML in Scala code right? it's not reserved in XML)
Contributor
|
Looks good! |
Member
|
LGTM |
|
Test build #55550 has finished for PR 12311 at commit
|
Member
|
retest this please. |
|
Test build #55575 has finished for PR 12311 at commit
|
|
Test build #2776 has finished for PR 12311 at commit
|
|
Test build #2778 has finished for PR 12311 at commit
|
Contributor
Author
|
@zsxwing Could you help me to fix the streaming test suite? It seems related to this PR. |
|
Test build #55622 has finished for PR 12311 at commit
|
Member
|
retest this please |
|
Test build #55638 has finished for PR 12311 at commit
|
Contributor
Author
|
Merging this into master, thanks! |
asfgit
pushed a commit
that referenced
this pull request
Apr 12, 2016
## What changes were proposed in this pull request? This PR improve the performance of SQL UI by: 1) remove the details column in all executions page (the first page in SQL tab). We can check the details by enter the execution page. 2) break-all is super slow in Chrome recently, so switch to break-word. 3) Using "display: none" to hide a block. 4) using one js closure for for all the executions, not one for each. 5) remove the height limitation of details, don't need to scroll it in the tiny window. ## How was this patch tested? Exists tests.  Author: Davies Liu <[email protected]> Closes #12311 from davies/ui_perf.
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
Apr 13, 2016
## What changes were proposed in this pull request? This PR improve the performance of SQL UI by: 1) remove the details column in all executions page (the first page in SQL tab). We can check the details by enter the execution page. 2) break-all is super slow in Chrome recently, so switch to break-word. 3) Using "display: none" to hide a block. 4) using one js closure for for all the executions, not one for each. 5) remove the height limitation of details, don't need to scroll it in the tiny window. ## How was this patch tested? Exists tests.  Author: Davies Liu <[email protected]> Closes apache#12311 from davies/ui_perf. (cherry picked from commit 582ed8a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR improve the performance of SQL UI by:
How was this patch tested?
Exists tests.