-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-14504][SQL] Enable Oracle docker tests #12270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR is dependent on PR #9893 |
|
Test build #55419 has finished for PR 12270 at commit
|
|
I just merged #9893 so this should be ready for a rebase. |
|
Ping RE: rebase. |
|
Test build #56018 has finished for PR 12270 at commit
|
|
Test build #56019 has finished for PR 12270 at commit
|
|
Test build #56021 has finished for PR 12270 at commit
|
|
Test build #56024 has finished for PR 12270 at commit
|
|
Test build #56030 has finished for PR 12270 at commit
|
|
Test build #56031 has finished for PR 12270 at commit
|
|
Test build #56042 has finished for PR 12270 at commit
|
|
Test build #56062 has finished for PR 12270 at commit
|
|
Jenkins, retest this |
|
Jenkins, retest this please. |
project/SparkBuild.scala
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The jar was getting a warning for checksum on maven build, and failing on sbt build... let me try removing it now that I explicitly pointed where the jar is for sbt, wich might make this change obsolete.
|
Test build #56087 has finished for PR 12270 at commit
|
|
Test build #56110 has finished for PR 12270 at commit
|
|
I'm a bit skeptical of some of the build hacks needed for this but out of pragmatism I'm going to merge this now and will just remove these tests later if this turns out to be unreliable. |
|
These tests are too flaky. I've already seen a few failures. We should disable them from the normal tests and maybe occasionally running them (via some trigger or just run it once before the release). |
|
I just failed to build Spark locally once due to the docker oracle test. |
|
@rxin, just trying to understand, is the oracle test the only one failing ? Or you are suggesting we move the whole docker based tests to a separate profile that would only run on Jenkins ? |
|
I don't even think they should run on pull requests. Tests that require extensive external setup (or downloading things) in general are flaky. |
|
@rxin Let me move them to a specific docker profile. But I would still run them on Jenkins, as the infrastructure is already setup there. |
|
They have been flaky and causing other pull requests to fail. That's why we shouldn't run them on Jenkins by default. |
|
We can run them via some trigger phrase though. |
|
Ok, I will work with @JoshRosen on the trigger part. |
## What changes were proposed in this pull request? Enable Oracle docker tests ## How was this patch tested? Existing tests Author: Luciano Resende <[email protected]> Closes apache#12270 from lresende/oracle.
What changes were proposed in this pull request?
Enable Oracle docker tests
How was this patch tested?
Existing tests