Skip to content

Conversation

@lresende
Copy link
Member

@lresende lresende commented Apr 9, 2016

What changes were proposed in this pull request?

Enable Oracle docker tests

How was this patch tested?

Existing tests

@lresende
Copy link
Member Author

lresende commented Apr 9, 2016

This PR is dependent on PR #9893

@SparkQA
Copy link

SparkQA commented Apr 9, 2016

Test build #55419 has finished for PR 12270 at commit 9f65ab3.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor

I just merged #9893 so this should be ready for a rebase.

@JoshRosen
Copy link
Contributor

Ping RE: rebase.

@SparkQA
Copy link

SparkQA commented Apr 16, 2016

Test build #56018 has finished for PR 12270 at commit f0790d5.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@lresende lresende changed the title [SPARK-14504] Enable Oracle docker tests [SPARK-14504][SQL] Enable Oracle docker tests Apr 16, 2016
@SparkQA
Copy link

SparkQA commented Apr 16, 2016

Test build #56019 has finished for PR 12270 at commit a78c9a7.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 16, 2016

Test build #56021 has finished for PR 12270 at commit bb6658a.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 16, 2016

Test build #56024 has finished for PR 12270 at commit 71b99d8.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 17, 2016

Test build #56030 has finished for PR 12270 at commit 1490ca0.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 17, 2016

Test build #56031 has finished for PR 12270 at commit 5b17a11.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 17, 2016

Test build #56042 has finished for PR 12270 at commit f281b43.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 17, 2016

Test build #56062 has finished for PR 12270 at commit a5ccec6.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@lresende
Copy link
Member Author

Jenkins, retest this

@lresende
Copy link
Member Author

Jenkins, retest this please.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jar was getting a warning for checksum on maven build, and failing on sbt build... let me try removing it now that I explicitly pointed where the jar is for sbt, wich might make this change obsolete.

@SparkQA
Copy link

SparkQA commented Apr 18, 2016

Test build #56087 has finished for PR 12270 at commit 9f92dc1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 18, 2016

Test build #56110 has finished for PR 12270 at commit 6b700e4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor

I'm a bit skeptical of some of the build hacks needed for this but out of pragmatism I'm going to merge this now and will just remove these tests later if this turns out to be unreliable.

@asfgit asfgit closed this in 68450c8 Apr 18, 2016
@rxin
Copy link
Contributor

rxin commented Apr 19, 2016

These tests are too flaky. I've already seen a few failures.

We should disable them from the normal tests and maybe occasionally running them (via some trigger or just run it once before the release).

@rxin
Copy link
Contributor

rxin commented Apr 19, 2016

I just failed to build Spark locally once due to the docker oracle test.

@lresende
Copy link
Member Author

@rxin, just trying to understand, is the oracle test the only one failing ? Or you are suggesting we move the whole docker based tests to a separate profile that would only run on Jenkins ?

@rxin
Copy link
Contributor

rxin commented Apr 19, 2016

I don't even think they should run on pull requests. Tests that require extensive external setup (or downloading things) in general are flaky.

@lresende
Copy link
Member Author

@rxin Let me move them to a specific docker profile. But I would still run them on Jenkins, as the infrastructure is already setup there.

@rxin
Copy link
Contributor

rxin commented Apr 19, 2016

They have been flaky and causing other pull requests to fail. That's why we shouldn't run them on Jenkins by default.

@rxin
Copy link
Contributor

rxin commented Apr 19, 2016

We can run them via some trigger phrase though.

@lresende
Copy link
Member Author

Ok, I will work with @JoshRosen on the trigger part.

lw-lin pushed a commit to lw-lin/spark that referenced this pull request Apr 20, 2016
## What changes were proposed in this pull request?

Enable Oracle docker tests

## How was this patch tested?

Existing tests

Author: Luciano Resende <[email protected]>

Closes apache#12270 from lresende/oracle.
@lresende lresende deleted the oracle branch May 7, 2016 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants