Skip to content

Conversation

@jkbradley
Copy link
Member

What changes were proposed in this pull request?

Cleanups to documentation. No changes to code.

  • GBT docs: Move Scala doc for private object GradientBoostedTrees to public docs for GBTClassifier,Regressor
  • GLM regParam: needs doc saying it is for L2 only
  • TrainValidationSplitModel: add .. versionadded:: 2.0.0
  • Rename “_transformer_params_from_java” to “_transfer_params_from_java”
  • LogReg Summary classes: “probability” col should not say “calibrated”
  • LR summaries: coefficientStandardErrors —> document that intercept stderr comes last. Same for t,p-values
  • approxCountDistinct: Document meaning of “rsd" argument.
  • LDA: note which params are for online LDA only

How was this patch tested?

Doc build

@jkbradley
Copy link
Member Author

CC @dbtsai Could you please confirm the doc changes about coefficientStandardErrors and GLM's regParam? Thanks!

@SparkQA
Copy link

SparkQA commented Apr 8, 2016

Test build #55394 has finished for PR 12266 at commit e746a17.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 8, 2016

Test build #55395 has finished for PR 12266 at commit 56acf90.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dbtsai
Copy link
Member

dbtsai commented Apr 9, 2016

Both looks good to me. Thanks. I'll go ahead and merge it soon.

@dbtsai
Copy link
Member

dbtsai commented Apr 9, 2016

Thanks. Merged into master.

@asfgit asfgit closed this in d7af736 Apr 9, 2016
@jkbradley
Copy link
Member Author

Thanks for taking a look!

@jkbradley jkbradley deleted the ml-doc-cleanups branch April 12, 2016 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants