[SPARK-13845][CORE][Backport-1.6]Using onBlockUpdated to replace onTaskEnd avioding driver OOM #12028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #54416 has finished for PR 12028 at commit
|
Contributor
Author
|
/cc @andrewor14 |
Contributor
|
Merged into 1.6 |
asfgit
pushed a commit
that referenced
this pull request
Mar 29, 2016
…askEnd avioding driver OOM ## What changes were proposed in this pull request? We have a streaming job using `FlumePollInputStream` always driver OOM after few days, here is some driver heap dump before OOM ``` num #instances #bytes class name ---------------------------------------------- 1: 13845916 553836640 org.apache.spark.storage.BlockStatus 2: 14020324 336487776 org.apache.spark.storage.StreamBlockId 3: 13883881 333213144 scala.collection.mutable.DefaultEntry 4: 8907 89043952 [Lscala.collection.mutable.HashEntry; 5: 62360 65107352 [B 6: 163368 24453904 [Ljava.lang.Object; 7: 293651 20342664 [C ... ``` `BlockStatus` and `StreamBlockId` keep on growing, and the driver OOM in the end. After investigated, i found the `executorIdToStorageStatus` in `StorageStatusListener` seems never remove the blocks from `StorageStatus`. In order to fix the issue, i try to use `onBlockUpdated` replace `onTaskEnd ` , so we can update the block informations(add blocks, drop the block from memory to disk and delete the blocks) in time. ## How was this patch tested? Existing unit tests and manual tests Author: jeanlyn <[email protected]> Closes #12028 from jeanlyn/fixoom1.6.
Contributor
|
Can you close this PR now? |
Contributor
Author
|
OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We have a streaming job using
FlumePollInputStreamalways driver OOM after few days, here is some driver heap dump before OOMBlockStatusandStreamBlockIdkeep on growing, and the driver OOM in the end.After investigated, i found the
executorIdToStorageStatusinStorageStatusListenerseems never remove the blocks fromStorageStatus.In order to fix the issue, i try to use
onBlockUpdatedreplaceonTaskEnd, so we can update the block informations(add blocks, drop the block from memory to disk and delete the blocks) in time.How was this patch tested?
Existing unit tests and manual tests