Skip to content

[BUGFIX][SQL] Should match java.math.BigDecimal when wnrapping Hive output #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
liancheng wants to merge 1 commit into from
Closed

[BUGFIX][SQL] Should match java.math.BigDecimal when wnrapping Hive output #1199

liancheng wants to merge 1 commit into from

Conversation

@liancheng
Copy link
Contributor

@liancheng liancheng commented Jun 24, 2014

The BigDecimal branch in unwrap matches to scala.math.BigDecimal rather than java.math.BigDecimal.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 24, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 24, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 24, 2014

Merged build finished.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 24, 2014

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16073/

@liancheng
Copy link
Contributor Author

liancheng commented Jun 25, 2014

I think the CachedTableSuite failed because TestData was not properly initialized. Is it related to running test cases in parallel?

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 25, 2014

Merged build triggered.

@liancheng
Copy link
Contributor Author

liancheng commented Jun 25, 2014

The problem is fixed by PR #1201, rebased to the most recent master.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 25, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 25, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 25, 2014

Merged build started.

@rxin
Copy link
Contributor

rxin commented Jun 25, 2014

Aren't we using Scala's BigDecimal?

@marmbrus
Copy link
Contributor

marmbrus commented Jun 25, 2014

@rxin we are probably using scala's but this code is unwrapping values that come from hive.

@rxin
Copy link
Contributor

rxin commented Jun 25, 2014

SGTM. We should probably switch to this: https://issues.apache.org/jira/browse/HIVE-6017 although it is a lower priority task (although for the purpose of API compatibility, maybe we want to make it higher priority0.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 25, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 25, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16090/

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 25, 2014

Merged build finished.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 25, 2014

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16095/

@liancheng
Copy link
Contributor Author

liancheng commented Jun 25, 2014

Weird, I can't reproduce the test failure locally, and the failed test case seems completely unrelated to the change...

@liancheng
Copy link
Contributor Author

liancheng commented Jun 25, 2014

@marmbrus Would you mind to retest this? Thanks.

@liancheng
Copy link
Contributor Author

liancheng commented Jun 25, 2014

OK, I reproduced it locally by running PruningSuite after HiveCompatibilitySuite. Investigating.

@rxin
Copy link
Contributor

rxin commented Jun 25, 2014

I'm going to merge this first since the test is most likely a different problem.

asfgit pushed a commit that referenced this pull request Jun 25, 2014
@liancheng @rxin
[BUGFIX][SQL] Should match java.math.BigDecimal when wnrapping Hive o…
65a559c 
…utput

The `BigDecimal` branch in `unwrap` matches to `scala.math.BigDecimal` rather than `java.math.BigDecimal`.

Author: Cheng Lian <[email protected]>

Closes #1199 from liancheng/javaBigDecimal and squashes the following commits:

e9bb481 [Cheng Lian] Should match java.math.BigDecimal when wnrapping Hive output

(cherry picked from commit 22036ae)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in 22036ae Jun 25, 2014
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
@liancheng @pdeyhim
[BUGFIX][SQL] Should match java.math.BigDecimal when wnrapping Hive o…
84b641b 
…utput

The `BigDecimal` branch in `unwrap` matches to `scala.math.BigDecimal` rather than `java.math.BigDecimal`.

Author: Cheng Lian <[email protected]>

Closes apache#1199 from liancheng/javaBigDecimal and squashes the following commits:

e9bb481 [Cheng Lian] Should match java.math.BigDecimal when wnrapping Hive output
@liancheng liancheng deleted the javaBigDecimal branch June 25, 2014 20:36
@liancheng
Copy link
Contributor Author

liancheng commented Jun 25, 2014

@rxin Solved the test failure in PR #1221.

xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@liancheng @conviva-zz
[BUGFIX][SQL] Should match java.math.BigDecimal when wnrapping Hive o…
a1c1d24 
…utput

The `BigDecimal` branch in `unwrap` matches to `scala.math.BigDecimal` rather than `java.math.BigDecimal`.

Author: Cheng Lian <[email protected]>

Closes apache#1199 from liancheng/javaBigDecimal and squashes the following commits:

e9bb481 [Cheng Lian] Should match java.math.BigDecimal when wnrapping Hive output
wangyum pushed a commit that referenced this pull request May 26, 2023
@allenma
[CARMEL-6490] Lots of unfinished state sql in the query log (#1199)
cb10771 
* [CARMEL-6490] Lots of unfinished state sql in the query log

* Fix ut
mapr-devops pushed a commit to mapr/spark that referenced this pull request May 8, 2025
@ekrivokonmapr
MapR [SPARK-1286] Pyspark + Panda integration doesn't work (apache#1199)
4031507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liancheng @AmplabJenkins @rxin @marmbrus