Skip to content

[SPARK-12653][SQL] Re-enable test "SPARK-8489: MissingRequirementError during reflection" #11744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 2 commits into from
Closed

[SPARK-12653][SQL] Re-enable test "SPARK-8489: MissingRequirementError during reflection" #11744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95f740f
[SPARK-12653] Re-enable test "SPARK-8489: MissingRequirementError dur…
dongjoon-hyun Mar 15, 2016
38b9752
Use exact pattern match to prevent future problem like Scala 2.12.
dongjoon-hyun Mar 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added sql/hive/src/test/resources/regression-test-SPARK-8489/test-2.10.jar
View file
Open in desktop
Binary file not shown.
Binary file added sql/hive/src/test/resources/regression-test-SPARK-8489/test-2.11.jar
View file
Open in desktop
Binary file not shown.
Binary file removed sql/hive/src/test/resources/regression-test-SPARK-8489/test.jar
View file
Open in desktop
Binary file not shown.
9 changes: 7 additions & 2 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import java.sql.Timestamp
import java.util.Date

import scala.collection.mutable.ArrayBuffer
import scala.tools.nsc.Properties

import org.scalatest.{BeforeAndAfterEach, Matchers}
import org.scalatest.concurrent.Timeouts
Expand Down Expand Up @@ -87,13 +88,17 @@ class HiveSparkSubmitSuite
runSparkSubmit(args)
}

ignore("SPARK-8489: MissingRequirementError during reflection") {
test("SPARK-8489: MissingRequirementError during reflection") {
// This test uses a pre-built jar to test SPARK-8489. In a nutshell, this test creates
// a HiveContext and uses it to create a data frame from an RDD using reflection.
// Before the fix in SPARK-8470, this results in a MissingRequirementError because
// the HiveContext code mistakenly overrides the class loader that contains user classes.
// For more detail, see sql/hive/src/test/resources/regression-test-SPARK-8489/*scala.
val testJar = "sql/hive/src/test/resources/regression-test-SPARK-8489/test.jar"
val version = Properties.versionNumberString match {
case v if v.startsWith("2.10") || v.startsWith("2.11") => v.substring(0, 4)
case x => throw new Exception(s"Unsupported Scala Version: $x")
}
val testJar = s"sql/hive/src/test/resources/regression-test-SPARK-8489/test-$version.jar"
val args = Seq(
"--conf", "spark.ui.enabled=false",
"--conf", "spark.master.rest.enabled=false",
Expand Down