[SPARK-13642][Yarn][1.6-backport] Properly handle signal kill in ApplicationMaster #11690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #53052 has finished for PR 11690 at commit
|
Contributor
There was a problem hiding this comment.
I assume his is merge issue? remove this function.
Contributor
Author
There was a problem hiding this comment.
Sorry, my bad, I will remove this.
|
Test build #53149 has finished for PR 11690 at commit
|
Contributor
Author
|
Jenkins, retest this please. |
|
Test build #53152 has finished for PR 11690 at commit
|
Contributor
Author
There was a problem hiding this comment.
I think here modifier is not allowed.
[error] /Users/sshao/projects/apache-spark/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala:126: illegal start of statement (no modifiers allowed here)
[error] private class AMSignalHandler(name: String) extends SignalHandler {
[error] ^
[error] one error found
Contributor
|
sorry for the delay on this, one minor comment otherwise looks good. |
jerryshao
force-pushed
the
SPARK-13642-1.6-backport
branch
2 times, most recently
from
ac7f73d to
b75927e
Compare
|
Test build #53897 has finished for PR 11690 at commit
|
|
Test build #53898 has finished for PR 11690 at commit
|
Contributor
|
+1 |
asfgit
pushed a commit
that referenced
this pull request
Mar 23, 2016
…icationMaster ## What changes were proposed in this pull request? This patch is fixing the race condition in ApplicationMaster when receiving a signal. In the current implementation, if signal is received and with no any exception, this application will be finished with successful state in Yarn, and there's no another attempt. Actually the application is killed by signal in the runtime, so another attempt is expected. This patch adds a signal handler to handle the signal things, if signal is received, marking this application finished with failure, rather than success. ## How was this patch tested? This patch is tested with following situations: Application is finished normally. Application is finished by calling System.exit(n). Application is killed by yarn command. ApplicationMaster is killed by "SIGTERM" send by kill pid command. ApplicationMaster is killed by NM with "SIGTERM" in case of NM failure. Author: jerryshao <[email protected]> Closes #11690 from jerryshao/SPARK-13642-1.6-backport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch is fixing the race condition in ApplicationMaster when receiving a signal. In the current implementation, if signal is received and with no any exception, this application will be finished with successful state in Yarn, and there's no another attempt. Actually the application is killed by signal in the runtime, so another attempt is expected.
This patch adds a signal handler to handle the signal things, if signal is received, marking this application finished with failure, rather than success.
How was this patch tested?
This patch is tested with following situations:
Application is finished normally.
Application is finished by calling System.exit(n).
Application is killed by yarn command.
ApplicationMaster is killed by "SIGTERM" send by kill pid command.
ApplicationMaster is killed by NM with "SIGTERM" in case of NM failure.