[SPARK-13622][YARN] Issue creating level db for YARN shuffle service #11475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ok to test |
|
Test build #52414 has finished for PR 11475 at commit
|
Contributor
Author
|
Please let me know if I need to update something in order to have this merge request accepted. |
Contributor
There was a problem hiding this comment.
URI.getPath() already returns a String, so the toString is redundant (also below).
Contributor
|
@ashangit sorry for the delay, just one minor comment otherwise looks good. |
ashangit
force-pushed
the
level_db_creation_issue
branch
from
c3e5833 to
50bb475
Compare
Contributor
Author
|
@vanzin thanks for the feedback. |
|
Test build #54349 has finished for PR 11475 at commit
|
Contributor
|
Merging to master, thanks! |
asfgit
pushed a commit
that referenced
this pull request
Mar 28, 2016
## What changes were proposed in this pull request? This patch will ensure that we trim all path set in yarn.nodemanager.local-dirs and that the the scheme is well removed so the level db can be created. ## How was this patch tested? manual tests. Author: nfraison <[email protected]> Closes #11475 from ashangit/level_db_creation_issue. (cherry picked from commit ff3bea3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch will ensure that we trim all path set in yarn.nodemanager.local-dirs and that the the scheme is well removed so the level db can be created.
How was this patch tested?
manual tests.