-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-13025] Allow users to set initial model in logistic regression #11459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Could you update the title with the Jira number? See here for more details. |
|
Can someone review this? |
|
This will be nice to have, but we should make |
|
@jkbradley initialModel is an instance of LogisticRegressionModel, I am not sure if I understand how to make it a Param? |
|
Should this wait until PR-11119 is merged? |
|
@jkbradley are we waiting to get this merged until PR-11119? |
|
Sorry for the delayed review. I'm worried that these PRs to set the initial model may need to change significantly if we merge Estimator & Model: [https://issues.apache.org/jira/browse/SPARK-14033] After the merge, setting an initial model may make less sense, for it would then be easier to copy the initial model and set some Boolean parameter indicating that fitting should begin from the current model. |
|
Test build #66726 has finished for PR 11459 at commit
|
|
Hi all, where are we on this? |
|
This can be closed. |
|
Hi, all, what about the status of this issue? why it was not merged? There are any ways to set |
# What changes were proposed in this pull request? This PR proposes to close stale PRs, mostly the same instances with apache#18017 Closes apache#11459 Closes apache#13833 Closes apache#13720 Closes apache#12506 Closes apache#12456 Closes apache#12252 Closes apache#17689 Closes apache#17791 Closes apache#18163 Closes apache#17640 Closes apache#17926 Closes apache#18163 Closes apache#12506 Closes apache#18044 Closes apache#14036 Closes apache#15831 Closes apache#14461 Closes apache#17638 Closes apache#18222 Added: Closes apache#18045 Closes apache#18061 Closes apache#18010 Closes apache#18041 Closes apache#18124 Closes apache#18130 Closes apache#12217 Added: Closes apache#16291 Closes apache#17480 Closes apache#14995 Added: Closes apache#12835 Closes apache#17141 ## How was this patch tested? N/A Author: hyukjinkwon <[email protected]> Closes apache#18223 from HyukjinKwon/close-stale-prs.
JIRA : SPARK - 13025
Modified access specifier to default(Public) to allow users to set initial model in logistic regression