Skip to content

Conversation

@GayathriMurali
Copy link
Contributor

JIRA : SPARK - 13025

Modified access specifier to default(Public) to allow users to set initial model in logistic regression

@sethah
Copy link
Contributor

sethah commented Mar 2, 2016

Could you update the title with the Jira number? See here for more details.

@GayathriMurali GayathriMurali changed the title Allow users to set initial model in logistic regression [SPARK-13025] Allow users to set initial model in logistic regression Mar 2, 2016
@GayathriMurali
Copy link
Contributor Author

Can someone review this?

@jkbradley
Copy link
Member

This will be nice to have, but we should make initialModel be a Param

@GayathriMurali
Copy link
Contributor Author

@jkbradley initialModel is an instance of LogisticRegressionModel, I am not sure if I understand how to make it a Param?

@sethah
Copy link
Contributor

sethah commented Mar 7, 2016

Should this wait until PR-11119 is merged?

@GayathriMurali
Copy link
Contributor Author

@jkbradley are we waiting to get this merged until PR-11119?

@jkbradley
Copy link
Member

Sorry for the delayed review. I'm worried that these PRs to set the initial model may need to change significantly if we merge Estimator & Model: [https://issues.apache.org/jira/browse/SPARK-14033] After the merge, setting an initial model may make less sense, for it would then be easier to copy the initial model and set some Boolean parameter indicating that fitting should begin from the current model.

@SparkQA
Copy link

SparkQA commented Oct 11, 2016

Test build #66726 has finished for PR 11459 at commit ab05aa6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Hi all, where are we on this?

@sethah
Copy link
Contributor

sethah commented May 24, 2017

This can be closed.

@lanisyutin
Copy link

Hi, all, what about the status of this issue? why it was not merged? There are any ways to set initialWeights now?

zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
# What changes were proposed in this pull request?

This PR proposes to close stale PRs, mostly the same instances with apache#18017

Closes apache#11459
Closes apache#13833
Closes apache#13720
Closes apache#12506
Closes apache#12456
Closes apache#12252
Closes apache#17689
Closes apache#17791
Closes apache#18163
Closes apache#17640
Closes apache#17926
Closes apache#18163
Closes apache#12506
Closes apache#18044
Closes apache#14036
Closes apache#15831
Closes apache#14461
Closes apache#17638
Closes apache#18222

Added:
Closes apache#18045
Closes apache#18061
Closes apache#18010
Closes apache#18041
Closes apache#18124
Closes apache#18130
Closes apache#12217

Added:
Closes apache#16291
Closes apache#17480
Closes apache#14995

Added:
Closes apache#12835
Closes apache#17141

## How was this patch tested?

N/A

Author: hyukjinkwon <[email protected]>

Closes apache#18223 from HyukjinKwon/close-stale-prs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants