[SPARK-6761][SQL][ML] Fixes to API and documentation of approximate quantiles#11325
Closed
thunterdb wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-6761][SQL][ML] Fixes to API and documentation of approximate quantiles#11325thunterdb wants to merge 3 commits intoapache:masterfrom
thunterdb wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
|
test this please |
| * Note on the target error: | ||
| * | ||
| * The result of this algorithm has the following deterministic bound: | ||
| * if the DataFrame has N elements and if we request the quantile `phi` up to error `epsi`, |
Contributor
There was a problem hiding this comment.
"the quantile corresponding to probability phi"
|
Test build #51778 has finished for PR 11325 at commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR addresses the remaining comments from @mengxr in #6042
How was the this patch tested?
This test passes the comprehensive test suite of the approximate quantiles, and adds more tests for the public API.