[SPARK-3650][GraphX] Triangle Count handles reverse edges incorrectly #11290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // This algorithm double counts each triangle so the final count should be even | ||
| val isEven = (dblCount & 1) == 0 | ||
| if (!isEven) { | ||
| throw new Exception("Triangle count resulted in an invalid number of triangles.") |
Member
There was a problem hiding this comment.
I would just require(...) this condition. (dblCount % 2) == 0 would be a little more canonical
Contributor
Author
|
@srowen good points, I've updated and pushed changes in line with your comments |
Member
|
Jenkins, test this please |
|
Test build #51640 has finished for PR 11290 at commit
|
Contributor
|
This looks good to me. @insidedctm thanks for reviving the PR and @srowen thanks for taking a look at this! My only minor concern is that it will change the results for people that are using triangle count so we should note this in the change log on the next release. |
Contributor
|
This is great timing given the next version is 2.0. |
Contributor
|
I'm going to merge this in master. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jegonzal @ankurdave please could you review
What changes were proposed in this pull request?
Reworking of @jegonzal PR #2495 to address the issue identified in SPARK-3650. Code amended to use the convertToCanonicalEdges method.
How was the this patch tested?
Patch was tested using the unit tests created in PR #2495