Skip to content

[SPARK-13153][PySpark] ML persistence failed when handle no default value parameter #11043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Wenpei wants to merge 3 commits into from
Closed

[SPARK-13153][PySpark] ML persistence failed when handle no default value parameter #11043

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60c80c1
fix spark-13153
Wenpei Feb 3, 2016
1af9637
replace isDefined with hasDefault
Wenpei Feb 3, 2016
06e06f7
reserve to isDefined
Wenpei Feb 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions python/pyspark/ml/wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,9 @@ def _transfer_params_from_java(self):
for param in self.params:
if self._java_obj.hasParam(param.name):
java_param = self._java_obj.getParam(param.name)
value = _java2py(sc, self._java_obj.getOrDefault(java_param))
self._paramMap[param] = value
if self._java_obj.hasDefault(java_param):
Copy link
Contributor

@yanboliang yanboliang Feb 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check by isDefined rather than hasDefault here.

value = _java2py(sc, self._java_obj.getOrDefault(java_param))
self._paramMap[param] = value

@staticmethod
def _empty_java_param_map():
Expand Down