[SPARK-12865][SPARK-12866][SQL] Migrate SparkSQLParser/ExtendedHiveQlParser commands to new Parser#10905
Closed
hvanhovell wants to merge 11 commits intoapache:masterfrom
Closed
[SPARK-12865][SPARK-12866][SQL] Migrate SparkSQLParser/ExtendedHiveQlParser commands to new Parser#10905hvanhovell wants to merge 11 commits intoapache:masterfrom
hvanhovell wants to merge 11 commits intoapache:masterfrom
Conversation
# Conflicts: # sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSQLParser.scala
Contributor
|
"The PR is marked WIP as long as it doesn't pass all tests." This is obvious so if you are only looking to run through the tests, we can just remove the WIP now. Then we don't need an extra roundtrip before merging. |
|
Test build #50039 has finished for PR 10905 at commit
|
Contributor
There was a problem hiding this comment.
if you are updating the pr, can you add explicit types for all the public vals?
Contributor
Author
There was a problem hiding this comment.
Removed TAB's...
|
Test build #50194 has finished for PR 10905 at commit
|
hvanhovell
changed the title
| lazy val source = stream.toString(startIndex, stopIndex) | ||
| lazy val source: String = stream.toString(startIndex, stopIndex) | ||
|
|
||
| /** Get the source text that remains after this token. */ |
Contributor
There was a problem hiding this comment.
would be great to briefly mention what this is used for (set?)
Contributor
|
I'm going to merge this. Please address the minor feedback in a follow-up pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves all the functionality provided by the SparkSQLParser/ExtendedHiveQlParser to the new Parser hierarchy (SparkQl/HiveQl). This also improves the current SET command parsing: the current implementation swallows
set role ...andset autocommit ...commands, this PR respects these commands (and passes them on to Hive).This PR and #10723 end the use of Parser-Combinator parsers for SQL parsing. As a result we can also remove the
AbstractSQLParserin Catalyst.The PR is marked WIP as long as it doesn't pass all tests.
cc @rxin @viirya @winningsix (this touches #10144)