Skip to content

[SPARK-12983] [CORE] [DOC] Correct metrics.properties.template#10902

Closed
BenFradet wants to merge 4 commits intoapache:masterfrom
BenFradet:SPARK-12983
Closed

[SPARK-12983] [CORE] [DOC] Correct metrics.properties.template#10902
BenFradet wants to merge 4 commits intoapache:masterfrom
BenFradet:SPARK-12983

Conversation

@BenFradet
Copy link
Contributor

There are some typos or plain unintelligible sentences in the metrics template.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here...

  • in the master
  • , and you can send
  • json -> JSON

@srowen
Copy link
Member

srowen commented Jan 25, 2016

LGTM, the rest are neutral or small improvements

@SparkQA
Copy link

SparkQA commented Jan 25, 2016

Test build #49999 has finished for PR 10902 at commit 348fd92.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • # qualified class name (see examples below).

@SparkQA
Copy link

SparkQA commented Jan 25, 2016

Test build #50018 has finished for PR 10902 at commit 9c45b8a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • # fully qualified class name (see examples below).

@BenFradet
Copy link
Contributor Author

Unrelated to this pr, triggering a new build.

@BenFradet
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jan 26, 2016

Test build #50075 has finished for PR 10902 at commit 9c45b8a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • # fully qualified class name (see examples below).

@BenFradet
Copy link
Contributor Author

cc @srowen and @JoshRosen since this is the spinoff of #10787`

@srowen
Copy link
Member

srowen commented Jan 27, 2016

merged to master

@asfgit asfgit closed this in 90b0e56 Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments