[SPARK-12885] [MINOR] Rename 3 fields in ShuffleWriteMetrics#10811
Closed
andrewor14 wants to merge 4 commits intoapache:masterfrom
Closed
[SPARK-12885] [MINOR] Rename 3 fields in ShuffleWriteMetrics#10811andrewor14 wants to merge 4 commits intoapache:masterfrom
andrewor14 wants to merge 4 commits intoapache:masterfrom
Conversation
|
Test build #49608 has finished for PR 10811 at commit
|
Contributor
Author
|
retest this please |
Conflicts: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala
Contributor
Author
|
retest this please |
|
Test build #49616 has finished for PR 10811 at commit
|
|
Test build #49628 has finished for PR 10811 at commit
|
Contributor
|
LGTM, so I'm going to merge this now. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small step in implementing SPARK-10620, which migrates TaskMetrics to accumulators. This patch is strictly a cleanup patch and introduces no change in functionality. It literally just renames 3 fields for consistency. Today we have:
The shuffle write ones are kind of redundant. We can drop the
shufflepart in the method names. I added backward compatible (but deprecated) methods with the old names.Parent PR: #10717