[SPARK-12525] Fix fatal compiler warnings in Kinesis ASL due to @transient annotations#10479
[SPARK-12525] Fix fatal compiler warnings in Kinesis ASL due to @transient annotations#10479JoshRosen wants to merge 5 commits intoapache:masterfrom
Conversation
|
Test build #48330 has finished for PR 10479 at commit
|
|
Test build #48332 has finished for PR 10479 at commit
|
|
Test build #48333 has finished for PR 10479 at commit
|
|
Test build #48334 has finished for PR 10479 at commit
|
|
LGTM |
There was a problem hiding this comment.
@skyluc @rxin, according to #8433 "if the class parameter are used in methods, then fields are created." I'm not sure how this applies in this case, where blockIds is also the name of a field in the superclass. In #8433, it looks like the fix was just to rename blockIds to _blockIds in order to avoid any ambiguity (see c1bc4f4#diff-b936e296c84502986961fb815d642458L64). Therefore, I'm going to make the same fix here for consistency's sake.
|
I'm only planning to merge this into 2.0.0. |
|
LGTM |
|
Jenkins, retest this please. |
1 similar comment
|
Jenkins, retest this please. |
|
Test build #48376 has finished for PR 10479 at commit
|
The Scala 2.11 SBT build currently fails for Spark 1.6.0 and master due to warnings about the
@transientannotation:This fix implemented here is the same as what we did in #8433: remove the
@transientannotations when they are not necessary and replace use@transient private valin the remaining cases.