Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Dec 21, 2015

JIRA: https://issues.apache.org/jira/browse/SPARK-12448

We should add UserDefinedType support to Cast.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For codgen case, the internal data for ExampleUDT here is double. Because of that, we cannot simply call checkEvaluation in this test.

@SparkQA
Copy link

SparkQA commented Dec 21, 2015

Test build #48110 has finished for PR 10410 at commit ab7cf32.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@marmbrus
Copy link
Contributor

I think we should hold off on this one too until we have a proper design for UDTs.

@viirya
Copy link
Member Author

viirya commented Dec 30, 2015

@marmbrus This is related to #10390. Do I need to submit them together in #10390 or leave this as separated one? Which is one better?

@marmbrus
Copy link
Contributor

marmbrus commented Jan 4, 2016

We can just merge the other PR once comments are addressed.

@viirya
Copy link
Member Author

viirya commented Jan 8, 2016

We don't need this pr now. Close it.

@viirya viirya closed this Jan 8, 2016
@viirya viirya deleted the cast-udt branch December 27, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants