[SPARK-2093] [SQL] NullPropagation should use exact type value. #1034
Conversation
|
Merged build triggered. |
|
Merged build started. |
There was a problem hiding this comment.
What do you think about casting here too, in case we ever change/specialize the return type of Count?
There was a problem hiding this comment.
I agree with that.
Even if we never change/specialize the return type, SimplifyCasts can remove the extra Cast.
And I'd like to change the Literal value for Sum to 0L to use SimplifyCasts for the case of the sum of integral values.
|
Merged build finished. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15611/ |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15619/ |
|
test this please |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15637/ |
|
I had to restart this test due to something unrelated. Jenkins, test this please. |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15640/ |
|
test this please |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15653/ |
|
Looks like only python tests are failing. Merged into 1.0 and master. Thanks! |
`NullPropagation` should use exact type value when transform `Count` or `Sum`. Author: Takuya UESHIN <[email protected]> Closes #1034 from ueshin/issues/SPARK-2093 and squashes the following commits: 65b6ff1 [Takuya UESHIN] Modify the literal value of the result of transformation from Sum to long value. 830c20b [Takuya UESHIN] Add Cast to the result of transformation from Count. 9314806 [Takuya UESHIN] Fix NullPropagation to use exact type value. (cherry picked from commit 0402bd7) Signed-off-by: Michael Armbrust <[email protected]>
`NullPropagation` should use exact type value when transform `Count` or `Sum`. Author: Takuya UESHIN <[email protected]> Closes apache#1034 from ueshin/issues/SPARK-2093 and squashes the following commits: 65b6ff1 [Takuya UESHIN] Modify the literal value of the result of transformation from Sum to long value. 830c20b [Takuya UESHIN] Add Cast to the result of transformation from Count. 9314806 [Takuya UESHIN] Fix NullPropagation to use exact type value.
`NullPropagation` should use exact type value when transform `Count` or `Sum`. Author: Takuya UESHIN <[email protected]> Closes apache#1034 from ueshin/issues/SPARK-2093 and squashes the following commits: 65b6ff1 [Takuya UESHIN] Modify the literal value of the result of transformation from Sum to long value. 830c20b [Takuya UESHIN] Add Cast to the result of transformation from Count. 9314806 [Takuya UESHIN] Fix NullPropagation to use exact type value.
…ket Scan Disabled by Planner (#1034)
4 participants
NullPropagationshould use exact type value when transformCountorSum.