Skip to content

Conversation

@gatorsmile
Copy link
Member

This PR is to add three more data types into Encoder, including BigDecimal, Date and Timestamp.

@marmbrus @cloud-fan @rxin Could you take a quick look at these three types? Not sure if it can be merged to 1.6. Thank you very much!

@SparkQA
Copy link

SparkQA commented Dec 8, 2015

Test build #47309 has finished for PR 10188 at commit 82d5d2b.

  • This patch fails Java style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testPrimitiveEncoder?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Thank you! Let me change it now.

@SparkQA
Copy link

SparkQA commented Dec 8, 2015

Test build #47310 has finished for PR 10188 at commit 968392b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 8, 2015

Test build #47311 has finished for PR 10188 at commit 8c51de4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

LGTM

@marmbrus
Copy link
Contributor

marmbrus commented Dec 8, 2015

Thanks, merging to master and 1.6

asfgit pushed a commit that referenced this pull request Dec 8, 2015
This PR is to add three more data types into Encoder, including `BigDecimal`, `Date` and `Timestamp`.

marmbrus cloud-fan rxin Could you take a quick look at these three types? Not sure if it can be merged to 1.6. Thank you very much!

Author: gatorsmile <[email protected]>

Closes #10188 from gatorsmile/dataTypesinEncoder.

(cherry picked from commit c0b13d5)
Signed-off-by: Michael Armbrust <[email protected]>
@asfgit asfgit closed this in c0b13d5 Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants