[SPARK-12060][Core]Avoid memory copy in JavaSerializerInstance.serialize #10051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM pending tests. |
Member
Author
|
retest this please |
|
Test build #46912 has finished for PR 10051 at commit
|
|
Test build #46917 has finished for PR 10051 at commit
|
Member
|
Yeah that looks nice, low-touch too. |
Member
Author
|
Merging to master and 1.6 |
asfgit
pushed a commit
that referenced
this pull request
Dec 1, 2015
…lize `JavaSerializerInstance.serialize` uses `ByteArrayOutputStream.toByteArray` to get the serialized data. `ByteArrayOutputStream.toByteArray` needs to copy the content in the internal array to a new array. However, since the array will be converted to `ByteBuffer` at once, we can avoid the memory copy. This PR added `ByteBufferOutputStream` to access the protected `buf` and convert it to a `ByteBuffer` directly. Author: Shixiong Zhu <[email protected]> Closes #10051 from zsxwing/SPARK-12060. (cherry picked from commit 1401166) Signed-off-by: Shixiong Zhu <[email protected]>
Member
Author
|
Just found a lot places use |
asfgit
pushed a commit
that referenced
this pull request
Dec 7, 2015
…lize Merged #10051 again since #10083 is resolved. This reverts commit 328b757. Author: Shixiong Zhu <[email protected]> Closes #10167 from zsxwing/merge-SPARK-12060.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaSerializerInstance.serializeusesByteArrayOutputStream.toByteArrayto get the serialized data.ByteArrayOutputStream.toByteArrayneeds to copy the content in the internal array to a new array. However, since the array will be converted toByteBufferat once, we can avoid the memory copy.This PR added
ByteBufferOutputStreamto access the protectedbufand convert it to aByteBufferdirectly.