[SPARK-12053][CORE] EventLoggingListener.getLogPath needs 4 parameters

[chutium]

EventLoggingListener.getLogPath needs 4 input arguments:
https://github.com/apache/spark/blob/v1.6.0-preview2/core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala#L276-L280

the 3rd parameter should be appAttemptId, 4th parameter is codec...

[vanzin]

Ah, good catch. While you're there, can you change the fourth parameter to explicitly have a name? e.g.:

getLogPath(foo, bar, baz, compressionCodecName = codec)

There should have been a warning on the output about that missing name, although it's pretty easy to ignore warnings... :-/

[chutium]

ha, yes, it happens, okey, i will add some parameter names

[andrewor14]

LGTM good catch

[SparkQA]

Test build #46897 has finished for PR 10044 at commit c9b20f9.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #46900 has finished for PR 10044 at commit 0b0a053.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[sarutak]

LGTM, merging into master, branch-1.6, branch-1.5 and branch-1.4. Thanks @chutium !

[sarutak]

I noticed we cannot merge this patch without modifying manually so I don't merge this into branch-1.4 for now. Please feel free to open another PR for branch-1.4.

[chutium]

thanks for merging, i will check this for branch-1.4

[chutium]

@sarutak it seems branch-1.4 was correct with EventLoggingListener.getLogPath
https://github.com/apache/spark/blob/v1.4.1/core/src/main/scala/org/apache/spark/deploy/master/Master.scala#L770-L771

the 3rd parameter None in this part of code was somehow missing after 1.5 ... :-o

[chutium]

it was caused by this commit about half year ago: 3bee0f1#diff-29dffdccd5a7f4c8b496c293e87c8668L771

hope no other small hidden bugs there... maybe worth a double check again

[sarutak]

Yeah, I also noticed that branch-1.4 has no issue discussed in this PR.