[SPARK-12029][SPARKR] Improve column functions signature, param check, tests, fix doc and add examples #10019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #46830 has finished for PR 10019 at commit
|
Contributor
There was a problem hiding this comment.
Are these signature changes just for our specific implementation of this generic ? i.e. the na.rm=F will still work for base R function but just not for SparkR ?
Member
Author
There was a problem hiding this comment.
Correct, since the generic is set properly.
There's a test in test_sparkSQL.R for stats::var with the y param
> var(1:5, 1:5)
[1] 2.5
> var(1:5, 1:5, na.rm=T)
[1] 2.5
> a
[1] 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 NA 20
> var(a)
[1] NA
> var(a, na.rm=T)
[1] 32.7193
Extra param y, na.rm can still be passed when calling var on a Column but they are ignored (just as before)
I discovered this while working on #9654 for colnames
setMethod("colnames",signature(x = "DataFrame"), function(x)
setGeneric("colnames", function(x, do.NULL = TRUE, prefix = "col")
Contributor
|
LGTM. Merging this |
asfgit
pushed a commit
that referenced
this pull request
Nov 29, 2015
…, tests, fix doc and add examples shivaram sun-rui Author: felixcheung <[email protected]> Closes #10019 from felixcheung/rfunctionsdoc. (cherry picked from commit 28e46ab) Signed-off-by: Shivaram Venkataraman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shivaram @sun-rui