[SPARK-45497][FOLLOWUP] Simplify symbolic link creation of spark-examples.jar#73
Merged
yaooqinn merged 2 commits intoapache:masterfrom Oct 8, 2024
Merged
[SPARK-45497][FOLLOWUP] Simplify symbolic link creation of spark-examples.jar#73yaooqinn merged 2 commits intoapache:masterfrom
yaooqinn merged 2 commits intoapache:masterfrom
Conversation
Member
Author
HyukjinKwon
approved these changes
Oct 8, 2024
Member
Author
|
Thanks @HyukjinKwon, Merged to master |
Member
|
Thank you, @HyukjinKwon and @yaooqinn . |
dongjoon-hyun
added a commit
to apache/spark
that referenced
this pull request
Oct 31, 2024
….jar` ### What changes were proposed in this pull request? This PR aims to simplify symbolic link creation of `spark-examples.jar` according to the downstream `docker-library` and `spark-docker` repository change. ### Why are the changes needed? - `docker-library` - docker-library/official-images#17622 (comment) - `spark-docker` - apache/spark-docker#73 - apache/spark-docker#74 - apache/spark-docker#76 ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #48723 from dongjoon-hyun/SPARK-50192. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Address comments docker-library/official-images#17622 (comment) from docker official owners
Why are the changes needed?
Use less fiddly subshell layers in between where things could unintentionally go wrong
Does this PR introduce any user-facing change?
no
How was this patch tested?