You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the collector's pathname is /skywalking, so the segments report request will send to http://IP/skywalking/v3/segments, and it's pathname is /skywalking/v3/segments, so the result of following code will be false:
// fetch.tsconstresponse=awaitorigFetch(...args);// should wrap with try catch to ensure that the error log and segment can be collected
Requirement or improvement
When the request send failed, The exitSpan's url tag in the fetch.ts and xhr.ts may be an empty string, such as the cors error. So i think it can be replaced with the request's url when the responseURL is empty.
// xhr.ts or fetch.tsconstexitSpan: SpanFields={
...
tags: options.detailMode
? [
...
{key: 'url',value: segCollector[i].event.responseURL// may be an empty string// maybe replae wih: segCollector[i].event.responseURL || `${url.protocol}//${url.host}${url.pathname}`},]};
The text was updated successfully, but these errors were encountered:
Please answer these questions before submitting your issue.
Bug
traceSDKInternal may not working
The
hasTrace
variable in thefetch.ts
andxhr.ts
may have wrong value, for example:the collector's pathname is
/skywalking
, so the segments report request will send tohttp://IP/skywalking/v3/segments
, and it's pathname is/skywalking/v3/segments
, so the result of following code will befalse
:fetch.ts should handle exception
Requirement or improvement
When the request send failed, The exitSpan's url tag in the
fetch.ts
andxhr.ts
may be an empty string, such as the cors error. So i think it can be replaced with the request's url when the responseURL is empty.The text was updated successfully, but these errors were encountered: