Replace storage with BanyanDB Cluster #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hanahmily
commented
May 31, 2024
•
hanahmily
commented
Signed-off-by: Gao Hongtao <[email protected]>
kezhenxu94
reviewed
May 31, 2024
Comment on lines
-54
to
+47
| test: [ "CMD-SHELL", "/skywalking/bin/swctl ch" ] | ||
| test: ["CMD", "bash", "-c", "cat < /dev/null > /dev/tcp/127.0.0.1/11800"] |
There was a problem hiding this comment.
Why do we want to change the health check of OAP?
There was a problem hiding this comment.
The image is missing swctl, which caused the startup to fail.
Comment on lines
+30
to
+33
| HELM_OPTIONS := $(HELM_OPTIONS) --set skywalking.banyandb.storage.persistentVolumeClaims[0].mountTargets[0]=stream | ||
| HELM_OPTIONS := $(HELM_OPTIONS) --set skywalking.banyandb.storage.persistentVolumeClaims[0].claimName=stream-data | ||
| HELM_OPTIONS := $(HELM_OPTIONS) --set skywalking.banyandb.storage.persistentVolumeClaims[0].size=10Gi | ||
| HELM_OPTIONS := $(HELM_OPTIONS) --set skywalking.banyandb.storage.persistentVolumeClaims[0].accessModes[0]=ReadWriteOnce |
There was a problem hiding this comment.
Let's move these into the values.yaml file as they are determined and not set via variables in Makefile
There was a problem hiding this comment.
I saw you already have these settings in values.yaml file so maybe we can remove them from here
There was a problem hiding this comment.
I tried following flags, but they didn't work
HELM_OPTIONS := $(HELM_OPTIONS) --set skywalking.banyandb.storage.persistentVolumeClaims[0].storageClass=$(STORAGE_CLASS)
HELM_OPTIONS := $(HELM_OPTIONS) --set skywalking.banyandb.storage.persistentVolumeClaims[1].storageClass=$(STORAGE_CLASS)
When I issues STORAGE_CLASS=ss make deploy.kubernetes, I got
storage:
persistentVolumeClaims:
- storageClass: ss
- storageClass: ss
The flags will override all fields of each item in the list. Therefore, I have to set all fields using flags.
kezhenxu94
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.