Update golang.org/x/tools to v0.34.0 for Go 1.25 compatibility#201
Merged
kezhenxu94 merged 1 commit intoapache:mainfrom Jun 14, 2025
stefanb:bump-golang.org/x/tools
Merged
Update golang.org/x/tools to v0.34.0 for Go 1.25 compatibility#201kezhenxu94 merged 1 commit intoapache:mainfrom stefanb:bump-golang.org/x/tools
kezhenxu94 merged 1 commit intoapache:mainfrom
stefanb:bump-golang.org/x/tools
Conversation
The build error with Go 1.25 manifests as: go1.25rc1 build ./... # golang.org/x/tools/internal/tokeninternal ../../../go/pkg/mod/golang.org/x/tools@v0.21.1-0.20240508182429-e35e4ccd0d2d/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64) updated via go get -u golang.org/x/tools go mod tidy Related: * Go proposal: golang/go#73205 * Upstream x/tools fix: https://go-review.googlesource.com/c/tools/+/675955 * Problem found in Homebrew/homebrew-core#226636
62 tasks
kezhenxu94
approved these changes
Jun 14, 2025
Member
|
@stefanb thanks! |
Contributor
Author
|
Please don't forget to make a release sometime before or right after Go 1.25 release. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build error with Go 1.25 manifests as:
updated via
Related:
golang.org/x/toolsfix: https://go-review.googlesource.com/c/tools/+/675955 / golang/tools@2815c8b