Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIRO-899] moved the HttpSessionContext Jakarta shim into Shiro pack… (1.11.x) #558

Merged

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Nov 30, 2022

…age and out of jakarta package to made Java modules work,
and avoid split package issues

1.11.x PR, same as #557

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SHIRO-XXX] - Fixes bug in SessionManager,
    where you replace SHIRO-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.

Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like (DOC) - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

…age and out of jakarta package,

to made JPMS work, and avoid split package issues
@lprimak lprimak force-pushed the native-sessions-jakarta-modular-1.11.x branch from 0bd4de5 to bb30889 Compare December 3, 2022 19:47
@lprimak lprimak merged commit a7de297 into apache:1.11.x Dec 7, 2022
@lprimak lprimak deleted the native-sessions-jakarta-modular-1.11.x branch December 7, 2022 17:15
@boris-petrov
Copy link
Contributor

@lprimak I've got a couple of questions:

  1. Isn't this missing the relocation part of the other PR?
  2. Shouldn't the pattern be jakarta.servlet.http.HttpSessionContext instead of javax.servlet.http.HttpSessionContext?
  3. I'm getting a java.lang.ClassNotFoundException: jakarta.servlet.http.HttpSessionContext when using Shiro 1.11.0 in a Jakarta environment (Tomcat 10). I'm definitely not sure if there isn't some problem in my configuration as I'm still figuring that out, however I noticed that change here and wanted to share my experience.

@lprimak
Copy link
Contributor Author

lprimak commented Jan 7, 2023

Hi, @boris-petrov

Isn't this missing the relocation part of the other PR?

Yes it does! My guess is that somehow this change was 'lost' in the cherry-pick / cleanup process.

  1. is incorrect because HttpSessionContext doesn't exist in Jakarta, hence the need for a workaround.
  2. is caused by 1

Thank you for the report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants