Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIRO-678] only query parameters for sessionID if found #317

Merged
merged 1 commit into from
Aug 18, 2021
Merged

[SHIRO-678] only query parameters for sessionID if found #317

merged 1 commit into from
Aug 18, 2021

Conversation

bmarwell
Copy link
Contributor

@bmarwell bmarwell commented Aug 12, 2021

  • getParameters() will also parse the body, which in turn decodes the content.
    avoid calling this method unless we know the sessionID can be in the query part.

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SHIRO-XXX] - Fixes bug in SessionManager,
    where you replace SHIRO-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.

Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like (DOC) - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Copy link
Member

@bdemers bdemers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good once the tests pass ;)

@fpapon fpapon self-requested a review August 13, 2021 08:01
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all the null check could be simplify but it's ok for now.
LGTM

@bmarwell bmarwell requested review from fpapon and bdemers August 13, 2021 09:17
@bmarwell
Copy link
Contributor Author

If okay for you, will squash the commits later today and then cherry-pick into 1.8.x.

 - getParameters() will also parse the body, which in turn decodes the content.
   avoid calling this method unless we know the sessionID can be in the query part.
 - getQueryString() can return null.
 - refactor out one level of nesting
@bmarwell bmarwell merged commit 41fb3ac into apache:main Aug 18, 2021
@bmarwell bmarwell deleted the SHIRO-678 branch August 18, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants