Pr 297 to main #298
Merged
Pr 297 to main #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set shiro.previousVersion to 1.7.1 (less critical, as main is a MAJOR change, but it will help track diffs and create a migration guide) * combine branch checks into single const Merged-from: #297
bmarwell
requested changes
May 7, 2021
.jenkins.groovy
Outdated
| @@ -17,6 +17,8 @@ | |||
| * under the License. | |||
| */ | |||
|
|
|||
| def supportedBranch = env.BRANCH_NAME ==~ /(1.7.x|1.8.x|main)/ | |||
There was a problem hiding this comment.
"supported"? Like in "we give support"? Maybe just change to "deployable branch" or "maintained" or something like this. It should be clear that this only has to do with snapshot deployments.
There was a problem hiding this comment.
Good call, I wasn't happy with this name either, deployableBranch sounds good to me!
There was a problem hiding this comment.
@bmarwell back to you when you get a chance
deployableBranch is a better name chan supportedBranch
bmarwell
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.