[SHIRO-805] Spelling #269

jsoref · 2020-12-22T07:05:31Z

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@c0e3b03#commitcomment-45334058

The action reports that the changes in this PR would make it happy: jsoref@276884c

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

Following this checklist to help us incorporate your contribution quickly and easily:

Make sure there is a JIRA issue filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
Each commit in the pull request should have a meaningful subject line and body.
Format the pull request title like [SHIRO-XXX] - Fixes bug in SessionManager,
where you replace SHIRO-XXX with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the commit message.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.

Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like (DOC) - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.

I expect to squash this PR near the end. But it's much easier for me to address review comments before squashing rather than after, as they generally address individual word families.

If there are files that you don't want changed, please let me know -- dropping them is fairly easy.

bmarwell · 2020-12-22T08:49:11Z

Thanks!
Can you kindly open a jira issue for this?

Btw, some classes get renamed. If they are not in a test folder, we'd need to let them misspelled the way they are.

web/src/main/java/org/apache/shiro/web/filter/mgt/PathMatchingFilterChainResolver.java

core/src/main/java/org/apache/shiro/session/Session.java

jsoref · 2020-12-22T15:41:09Z

For the curious, this forced push just folded 8fce45c into 8fd6e14.

It sounds like I'm going to split this PR into a couple of pieces, and it's helpful if my commits are reasonably labeled before I do that.

jsoref · 2020-12-22T16:57:42Z

This is now roughly:

tests
comments
docs

The commits I've dropped are variable/function/class renames. Note for simplicity, if a code rename includes a comment change, that was included.

fpapon · 2021-02-19T12:34:10Z

@jsoref can you squash the commits please?

jsoref · 2021-02-19T15:38:36Z

(This is just a rebased version before squashing.)

jsoref · 2021-04-12T02:26:38Z

@fpapon ?

bmarwell · 2021-04-14T10:36:03Z

Maybe just #269 (comment) left, then we are good imho.

fpapon

LGTM

bmarwell

some nits

core/src/main/java/org/apache/shiro/authc/pam/ModularRealmAuthenticator.java

bmarwell · 2021-08-02T07:44:21Z

core/src/main/java/org/apache/shiro/session/Session.java

-     * authentication state that might exist, thereby effectively &quot;unauthenticating&quot; the {@code Subject}.
+     * authentication state that might exist, thereby effectively removing the &quot;authenticated&quot; state of the {@code Subject}.


Not 100% sure about this one. I know "to unauthenticate" is not a common word, but it is easier to understand than "removing the >authenticated<-state".

unauthenticate really isn't a word. Conceptually the word would be deauthenticate (but even that isn't in Google Chrome's dictionary -- nor is it in the dictionary I'm using, although I'd be ok w/ it).

Maybe @bdemers can think of something else?

core/src/test/java/org/apache/shiro/realm/jdbc/JDBCRealmTest.java

jsoref · 2021-08-02T08:33:09Z

Fwiw, I'm trying to update this PR, I have everything resolved, but there's quite a bit of additional drift between when I started and now... So, I'm also trying to get my tool to give new happier output.

bmarwell · 2021-08-02T09:24:11Z

Fwiw, I'm trying to update this PR, I have everything resolved, but there's quite a bit of additional drift between when I started and now... So, I'm also trying to get my tool to give new happier output.

Sorry it took us so long. Shouldn't happen again! :)

* account * against * and * application * authentication * authorization * authorizer * automatically * axes * both * build * case * consistent * contains * control * controls * created * deauthenticating * defaults * defined * delimited * delimiter * deserialized * deserializes * e.g. * efficient * encapsulate * encryption * environment * et al. * etc. * evaluate * evaluator * exception * explicitly * false * filters * from * hash format * hashed * hierarchy * i.e. * identifier * identifying * immediately * implementation * implementers * inferring * injectable * iterator * join point * manner * modifier * nonexistent * obtained * overridden * password * performing * permission * permissions * preemptively * recognized * reget * remnant * request * required * resolvable * returned * safely * session * subsequent * successfully * type * undertow * usually * wield Signed-off-by: Josh Soref <[email protected]>

bmarwell · 2021-08-04T08:14:47Z

core/src/main/java/org/apache/shiro/realm/activedirectory/ActiveDirectoryRealm.java

@@ -159,8 +159,8 @@ protected AuthorizationInfo buildAuthorizationInfo(Set<String> roleNames) {
        Set<String> roleNames;
        roleNames = new LinkedHashSet<String>();

-        SearchControls searchCtls = new SearchControls();


Not strictly necessary, but ok for me.

fpapon · 2021-08-04T10:13:04Z

@jsoref thanks for your contribution!

sunshineandy · 2021-08-05T00:30:33Z

view it on GitHub

…

------------------ 原始邮件 ------------------ 发件人: "apache/shiro" ***@***.***>; 发送时间: 2021年8月4日(星期三) 晚上6:13 ***@***.***>; ***@***.***>; 主题: Re: [apache/shiro] [SHIRO-805] Spelling (#269) @jsoref thanks for your contribution! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

jsoref changed the title ~~Spelling~~ [SHIRO-805] Spelling Dec 22, 2020

bdemers reviewed Dec 22, 2020

View reviewed changes

web/src/main/java/org/apache/shiro/web/filter/mgt/PathMatchingFilterChainResolver.java Outdated Show resolved Hide resolved

bdemers reviewed Dec 22, 2020

View reviewed changes

core/src/main/java/org/apache/shiro/session/Session.java Outdated Show resolved Hide resolved

jsoref force-pushed the spelling branch from 8fce45c to 5211e98 Compare December 22, 2020 15:38

jsoref force-pushed the spelling branch from 5211e98 to 4491ddc Compare December 22, 2020 16:53

jsoref force-pushed the spelling branch from 4491ddc to 6011820 Compare February 19, 2021 15:38

jsoref force-pushed the spelling branch 2 times, most recently from e2f648b to dcb9e4b Compare February 19, 2021 15:40

jsoref force-pushed the spelling branch from dcb9e4b to 21c0661 Compare April 14, 2021 11:20

fpapon self-requested a review April 14, 2021 16:08

fpapon approved these changes Apr 14, 2021

View reviewed changes

fpapon requested review from bdemers and bmarwell April 16, 2021 09:45

bmarwell requested changes Aug 2, 2021

View reviewed changes

jsoref force-pushed the spelling branch from 21c0661 to 99f43de Compare August 2, 2021 13:12

jsoref force-pushed the spelling branch from 99f43de to 897cd31 Compare August 2, 2021 13:26

bdemers approved these changes Aug 2, 2021

View reviewed changes

bmarwell approved these changes Aug 4, 2021

View reviewed changes

fpapon merged commit 0c0d9da into apache:main Aug 4, 2021

jsoref deleted the spelling branch August 4, 2021 15:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SHIRO-805] Spelling #269

[SHIRO-805] Spelling #269

jsoref commented Dec 22, 2020

bmarwell commented Dec 22, 2020

jsoref commented Dec 22, 2020

jsoref commented Dec 22, 2020

fpapon commented Feb 19, 2021

jsoref commented Feb 19, 2021

jsoref commented Apr 12, 2021

bmarwell commented Apr 14, 2021

fpapon left a comment

bmarwell left a comment

bmarwell Aug 2, 2021

jsoref Aug 2, 2021

bmarwell Aug 2, 2021

jsoref commented Aug 2, 2021

bmarwell commented Aug 2, 2021

bmarwell Aug 4, 2021

fpapon commented Aug 4, 2021

sunshineandy commented Aug 5, 2021 via email

		* authentication state that might exist, thereby effectively "unauthenticating" the {@code Subject}.
		* authentication state that might exist, thereby effectively removing the "authenticated" state of the {@code Subject}.

[SHIRO-805] Spelling #269

[SHIRO-805] Spelling #269

Conversation

jsoref commented Dec 22, 2020

bmarwell commented Dec 22, 2020

jsoref commented Dec 22, 2020

jsoref commented Dec 22, 2020

fpapon commented Feb 19, 2021

jsoref commented Feb 19, 2021

jsoref commented Apr 12, 2021

bmarwell commented Apr 14, 2021

fpapon left a comment

Choose a reason for hiding this comment

bmarwell left a comment

Choose a reason for hiding this comment

bmarwell Aug 2, 2021

Choose a reason for hiding this comment

jsoref Aug 2, 2021

Choose a reason for hiding this comment

bmarwell Aug 2, 2021

Choose a reason for hiding this comment

jsoref commented Aug 2, 2021

bmarwell commented Aug 2, 2021

bmarwell Aug 4, 2021

Choose a reason for hiding this comment

fpapon commented Aug 4, 2021

sunshineandy commented Aug 5, 2021 via email