Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIRO-767] Fixed issue where ClassUtil cannot load the array of Primitive DataType... #248

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

ddddyyyy
Copy link
Contributor

...when use undertown as web container

@fpapon fpapon self-requested a review August 15, 2020 17:03
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddddyyyy Can you squash the commits please?
Thanks for the PR!

…load the array of Primitive DataType when use undertown as web container

Use Class.forName instead of cl.loadClass().
Support for getting primitive data type by a static map.
Copy link
Contributor

@bmarwell bmarwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpapon fpapon merged commit 41d3f7a into apache:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants