Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SHIRO-777] remove powermock. #235

Merged
merged 1 commit into from
May 12, 2020
Merged

[SHIRO-777] remove powermock. #235

merged 1 commit into from
May 12, 2020

Conversation

bmarwell
Copy link
Contributor

This test will now actually start hazelcast. If this is not feasible, just add a corresponding comment to this PR.

@bmarwell bmarwell requested review from coheigea and fpapon May 11, 2020 17:27
@bmarwell
Copy link
Contributor Author

  • Added enforcer plugin
  • Does not actually start hazelcast anymore due to overriding the create method (which is now untested).

@fpapon
Copy link
Member

fpapon commented May 12, 2020

retest this please

fpapon
fpapon approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmarwell bmarwell removed the request for review from coheigea May 12, 2020 09:32
@bmarwell
Copy link
Contributor Author

@fpapon restest:

@fpapon fpapon merged commit 5be3a50 into apache:master May 12, 2020
@bmarwell bmarwell deleted the SHIRO-777-powermock branch May 12, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpapon fpapon fpapon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmarwell @fpapon