Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SHIRO-772] Remove PowerMock from EnvironmentLoaderServiceTest.java. #230

Merged
merged 1 commit into from
May 9, 2020
Merged

[SHIRO-772] Remove PowerMock from EnvironmentLoaderServiceTest.java. #230

merged 1 commit into from
May 9, 2020

Conversation

bmarwell
Copy link
Contributor

@bmarwell bmarwell commented May 9, 2020

  • Enables building with JDK11 and 14
  • refactored ServiceLoader loading into separate method to enable mocking.

@bmarwell
[SHIRO-772] Remove PowerMock from EnvironmentLoaderServiceTest.java.
3f339f3 
  - Enables building with JDK11 and 14
  - refactored ServiceLoader loading into separate method to enable mocking.
@fpapon fpapon self-requested a review May 9, 2020 12:24
fpapon
fpapon approved these changes May 9, 2020
View reviewed changes
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
LGTM

@fpapon fpapon merged commit 930380c into apache:master May 9, 2020
@bmarwell bmarwell deleted the SHIRO-772-powermock branch May 9, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpapon fpapon fpapon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmarwell @fpapon