Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SHIRO-750] update jax-rs dependency to jakarta. #226

Merged
merged 1 commit into from
May 8, 2020
Merged

[SHIRO-750] update jax-rs dependency to jakarta. #226

merged 1 commit into from
May 8, 2020

Conversation

bmarwell
Copy link
Contributor

@bmarwell bmarwell commented May 8, 2020

  • Non-Breaking change.
  • Also set the scope to provided. Containers will provide this API.
  • Also add the dependency to the samples, so they do not use a
    transitive dependency.

@bmarwell
[SHIRO-750] update jax-rs dependency to jakarta.
3887e5d 
  - Non-Breaking change.
  - Also set the scope to provided. Containers will provide this API.
  - Also add the dependency to the samples, so they do not use a
  transitive dependency.
@fpapon fpapon self-requested a review May 8, 2020 14:35
fpapon
fpapon approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Jenkins job are ok, thanks!

@fpapon fpapon merged commit 6a4f7e2 into apache:master May 8, 2020
@bmarwell bmarwell deleted the SHIRO-750 branch May 9, 2020 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpapon fpapon fpapon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmarwell @fpapon