SHIRO-708 - Remove deprecated shiro-cas module #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refer to this link for build results (access rights to CI server needed): |
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): |
|
We need to think about how we message this. If the next version is 1.5 and we remove a module that is a breaking change at a high level. But not at an actual code level. |
|
@bdemers the module is deprecated in the current website page https://shiro.apache.org/cas.html |
|
@bdemers We are moving now on 2.0.0, I think we could remove this module. |
|
@fpapon absolutely! 🗑️ |
|
@coheigea can you rebase and resolve the conflicting files please? |
coheigea
force-pushed
the
SHIRO-708
branch
2 times, most recently
from
2bc0e6f to
56bd161
Compare
|
@fpapon Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.