-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1005] - Expand checkstyle to all modules (root). #1069
Conversation
Hi, @damonxue |
I have started the review process. So far it looks great! |
One comment: |
Also, please do not close this PR, force-push or open another one, or make more massive changes. I can't devote 5+ hours to start from the beginning again. Thank you! Overall, great job, we are close to approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@damonxue can you squash the commits and rebase from main?
@damonxue thank you for the great work! |
@damonxue please don't squash the commit just yet. I will let you know. I am not done with my review / changes. |
@damonxue I am done with my changes. Feel free to squash the commits, or let me know if you want me to do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I have rebased & squashed the commits. Should be good to go tomorrow :) |
fixes #1005
Reformatted all the code to conform to checkstyle rules
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
Following this checklist to help us incorporate your contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
[#XXX] - Fixes bug in SessionManager
,where you replace
#XXX
with the appropriate GitHub issue. Best practiceis to use the GitHub issue title in the pull request title and in the first line of the commit message.
fixes #XXX
if merging the PR should close a related issue.mvn verify
to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i
.Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like
[DOC] - Add javadoc in SessionManager
.If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.
I attest that I had signed an [Individual Contributor License Agreement] in
Apache ShenYu
project.