Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] AspectJ tests fail when compiling subsequent times from root #1100

Closed
1 task done
lprimak opened this issue Oct 4, 2023 · 0 comments · Fixed by #1103
Closed
1 task done

[Bug] AspectJ tests fail when compiling subsequent times from root #1100

lprimak opened this issue Oct 4, 2023 · 0 comments · Fixed by #1103
Assignees
@lprimak
Labels
build shiro-2.0.0
Milestone
2.0

Comments

@lprimak
Copy link
Contributor

lprimak commented Oct 4, 2023 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar issues.

Environment

Any

Shiro version

main branch (2.x)

What was the actual outcome?

Tests failed on AspectJ

What was the expected outcome?

AspectJ tests succeed

How to reproduce

mvn package twice. first time it succeeds. Second (and subsequent) times it fails
This happens when compiling from Shiro root only.

Debug logs

No response
@lprimak lprimak added this to the 2.0 milestone Oct 4, 2023
@lprimak lprimak self-assigned this Oct 4, 2023
@lprimak lprimak mentioned this issue Oct 4, 2023
Merged
10 tasks
@lprimak lprimak changed the title [Bug] AspectJ tests fail when compiling subsequent times [Bug] AspectJ tests fail when compiling subsequent times from root Oct 4, 2023
lprimak added a commit that referenced this issue Oct 4, 2023
@lprimak
Merge pull request #1103 from lprimak/aspectj-test-fix
2d92460 
[#1100] - bugfix(build): force AspectJ compilation every time, as it doesn't detect…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lprimak lprimak

Labels
build shiro-2.0.0
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

[#1100] - bugfix(build): force AspectJ compilation every time, as it doesn't detect… lprimak/shiro
1 participant
@lprimak