Skip to content

Commit

Permalink
deleteMe cookie should use the defined "sameSite"
Browse files Browse the repository at this point in the history
With Chrome increasing security of cookies not defining any SameSite options, the deleteMe cookie may be blocked by Chrome under some circumstances.
For example, when an app is used within a cross-site iframe, one must defined the option SameSite=None option. This works for the main cookie, but the deleteMe is currently blocked. This commit fixes this.
  • Loading branch information
FredTreg authored Oct 1, 2020
1 parent df227ac commit c5e8075
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ public void removeFrom(HttpServletRequest request, HttpServletResponse response)
int version = getVersion();
boolean secure = isSecure();
boolean httpOnly = false; //no need to add the extra text, plus the value 'deleteMe' is not sensitive at all
SameSiteOptions sameSite = null;
SameSiteOptions sameSite = getSameSite();

addCookieHeader(response, name, value, comment, domain, path, maxAge, version, secure, httpOnly, sameSite);

Expand Down

0 comments on commit c5e8075

Please sign in to comment.