Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[type:bugfix]Add more retry strategies #5969

Merged
merged 24 commits into from
Apr 2, 2025
Merged

[type:bugfix]Add more retry strategies #5969

merged 24 commits into from
Apr 2, 2025
+571 −91

Conversation

JerryDtj
Copy link
Contributor

修复了#5920,保持原有代码不变的基础上,重构了AbstractHttpClientPlugin.让它支持更多的重试策略
Fixes #5920 ,On the basis of keeping the original code unchanged, we refactored AbstractFHIR Plugin Enable it to support more retry strategies

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

Aias00
Aias00 requested changes Mar 25, 2025
View reviewed changes
shenyu-common/src/main/java/org/apache/shenyu/common/constant/Constants.java Outdated
@@ -960,7 +960,11 @@ public interface Constants {
* The constant Content-Encoding.
*/
String CONTENT_ENCODING = "Content-Encoding";

/**
* http请求重试策略 http request retry policy.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use English, pls

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,i fix it

shenyu-common/src/main/java/org/apache/shenyu/common/enums/HttpRetryBackoffSpecEnum.java Outdated
public enum HttpRetryBackoffSpecEnum {

/**
* 默认重试.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use English, pls

shenyu-common/src/main/java/org/apache/shenyu/common/enums/HttpRetryBackoffSpecEnum.java Outdated
DEFAULT_BACKOFF("default"),

/**
* 固定重试.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use English, pls

shenyu-common/src/main/java/org/apache/shenyu/common/enums/HttpRetryBackoffSpecEnum.java Outdated
FIXED_BACKOFF("fixed"),

/**
* 指数重试.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use English, pls

shenyu-common/src/main/java/org/apache/shenyu/common/enums/HttpRetryBackoffSpecEnum.java Outdated
EXPONENTIAL_BACKOFF("exponential"),

/**
* 自定义重试.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use English, pls

...lugin-httpclient/src/main/java/org/apache/shenyu/plugin/httpclient/DefaultRetryStrategy.java Outdated


/**
* 默认重试策略类 Default Retry Policy Class
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use English, pls

...lient/src/main/java/org/apache/shenyu/plugin/httpclient/ExponentialRetryBackoffStrategy.java Outdated
}

/**
* 执行重试策略
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use English, pls

...-plugin-httpclient/src/main/java/org/apache/shenyu/plugin/httpclient/FixedRetryStrategy.java Outdated
}

/**
* 执行重试策略
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use English, pls

...henyu-plugin-httpclient/src/main/java/org/apache/shenyu/plugin/httpclient/RetryStrategy.java Outdated
import java.time.Duration;

/**
* 重试策略接口 Retry Policy Interface
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use English, pls

...u-plugin-httpclient/src/test/java/org/apache/shenyu/plugin/httpclient/RetryStrategyTest.java Outdated

@Test
void testDefaultRetryBackoffExecute() {
// 创建一个模拟的 AbstractHttpClientPlugin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use English, pls

@JerryDtj JerryDtj requested a review from Aias00 March 25, 2025 17:09
@Aias00
Copy link
Contributor

Aias00 commented Mar 26, 2025

fix ci error pls

@Aias00
Copy link
Contributor

Aias00 commented Mar 27, 2025

fix the ci
u should do the checkstyle local, before submit the code

@JerryDtj
Copy link
Contributor Author

fix the ci u should do the checkstyle local, before submit the code

好的,多谢,版本已经提交

@Aias00 Aias00 added this to the 2.7.0.1 milestone Mar 31, 2025
Aias00
Aias00 approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@Aias00 Aias00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aias00 Aias00 merged commit 909704f into apache:master Apr 2, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aias00 Aias00 Aias00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.0.1
2 participants
@JerryDtj @Aias00