Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supported or in where clause(支持or语句) #737

Merged
merged 9 commits into from
Apr 18, 2018
Merged

Supported or in where clause(支持or语句) #737

merged 9 commits into from
Apr 18, 2018

Conversation

maxiaoguang64
Copy link
Collaborator

@maxiaoguang64 maxiaoguang64 commented Apr 17, 2018 •
edited
Loading

@codecov-io
Copy link

codecov-io commented Apr 17, 2018 •
edited
Loading

Codecov Report

Merging #737 into dev will increase coverage by 0.32%.
The diff coverage is 78.26%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev    #737      +/-   ##
=========================================
+ Coverage   65.38%   65.7%   +0.32%     
=========================================
  Files         478     478              
  Lines        9218    9261      +43     
  Branches     1513    1527      +14     
=========================================
+ Hits         6027    6085      +58     
+ Misses       2865    2847      -18     
- Partials      326     329       +3
Impacted Files Coverage Δ
...e/routing/type/standard/StandardRoutingEngine.java 0% <0%> (ø) ⬆️
.../parsing/parser/context/condition/OrCondition.java 89.47% <100%> (+11.69%) ⬆️
...parsing/parser/context/condition/AndCondition.java 95.83% <100%> (+2.08%) ⬆️
...re/parsing/parser/context/condition/Condition.java 84.44% <100%> (+1.51%) ⬆️
.../core/parsing/parser/clause/WhereClauseParser.java 92.59% <95.65%> (-0.15%) ⬇️
...rdingjdbc/core/jdbc/metadata/ShardingMetaData.java 0% <0%> (ø) ⬆️
...jdbc/metadata/handler/TableMetaHandlerFactory.java
...jdbc/core/jdbc/metadata/entity/ColumnMetaData.java
...gjdbc/core/jdbc/metadata/entity/TableMetaData.java
...dbc/metadata/handler/AbstractTableMetaHandler.java
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7562ceb...bd2a936. Read the comment docs.

@maxiaoguang64
1、Fix bug when parse or condition contains no sharding column(修复非分片键在…
90f4721 
…or语句中解析不正确bug)

2、Add test case for or(增加or的测试用例)
@maxiaoguang64
code restructuring(重构代码)
2632b00
@maxiaoguang64
Support or in routing(路由支持or)
8eb3252
@maxiaoguang64
1、Remove WhereClauseParser.parseWhere() bug code(删除WhereClauseParser.…
f5a8f23 
…parseWhere()中多余的代码)

2、Rename trim to optimize in AndCondition and OrCondition(重命名AndCondition和OrCondition中的trim为optimize)
3、Add test case for or(添加or的测试用例)
@maxiaoguang64
For checkstyle
bd2a936
@maxiaoguang64 maxiaoguang64 changed the title Support or condition in where clause parser(sql解析时支持or) Supported or in where clause(支持or语句) Apr 18, 2018
@terrymanu terrymanu merged commit 9e16ec8 into apache:dev Apr 18, 2018
@terrymanu terrymanu mentioned this pull request Apr 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxiaoguang64 @codecov-io @terrymanu