-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
实现Or的准备工作 #703
实现Or的准备工作 #703
Conversation
2、修改Conditions中add方法默认像第一个and conditions添加condition 3、修改Conditions中find方法默认获取第一个and conditions分片键相同的最后一个condition 4、修改测试用例
Codecov Report
@@ Coverage Diff @@
## dev #703 +/- ##
=========================================
+ Coverage 67.9% 67.96% +0.06%
=========================================
Files 452 454 +2
Lines 8653 8698 +45
Branches 1399 1408 +9
=========================================
+ Hits 5876 5912 +36
- Misses 2454 2456 +2
- Partials 323 330 +7
Continue to review full report at Codecov.
|
2、去掉Conditions类中get方法
Code review suggestion: |
Code review suggestions:
public Optional<Condition> find(final Column column, final int index) {
Optional<AndConditions> andConditions = get(index);
return andConditions.isPresent() ? andConditions.get().find(column) : Optional.<Condition>absent();
}
|
相关issue
1、修改Conditions中conditions的类型
2、修改Conditions中add方法默认像第一个and conditions添加condition
3、修改Conditions中find方法默认获取第一个and conditions分片键相同的最后一个condition
4、修改测试用例