Skip to content

Conversation

@linghengqian
Copy link
Member

For #37642 .

Changes proposed in this pull request:

  • Document the process of running nativeTest via Docker Engine v29 .

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@linghengqian linghengqian marked this pull request as ready for review January 5, 2026 09:15
@linghengqian linghengqian requested a review from Copilot January 5, 2026 09:15
@linghengqian linghengqian added this to the 5.5.3 milestone Jan 5, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR documents the process of running nativeTest via Docker Engine v29 by refactoring PowerShell scripts and updating installation documentation across multiple languages.

Key Changes:

  • Refactored Rancher Desktop setup by extracting configuration logic into a dedicated config-rdctl.ps1 script
  • Updated Docker Engine installation instructions to use the new DEB822 repository format and configure daemon.json with min-api-version: 1.24
  • Added comprehensive Docker daemon configuration for Rancher Desktop on Windows including containerd-snapshotter feature

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/native/src/test/resources/test-native/ps1/wait-for-rancher-desktop-backend.ps1 Removed Rancher Desktop installation commands, keeping only the wait/polling logic
test/native/src/test/resources/test-native/ps1/config-rdctl.ps1 New script that consolidates Rancher Desktop installation, configuration, and wait steps for GitHub Actions
docs/document/content/user-manual/shardingsphere-proxy/startup/graalvm-native-image.en.md Updated Docker Engine installation to use DEB822 format, added daemon.json configuration, and expanded Rancher Desktop setup instructions
docs/document/content/user-manual/shardingsphere-proxy/startup/graalvm-native-image.cn.md Chinese version of the above documentation changes
docs/document/content/user-manual/shardingsphere-jdbc/graalvm-native-image/development/_index.en.md Applied same Docker Engine and Rancher Desktop documentation updates for JDBC module
docs/document/content/user-manual/shardingsphere-jdbc/graalvm-native-image/development/_index.cn.md Chinese version of the JDBC documentation changes
.github/workflows/nightly-ci.yml Updated to use the new config-rdctl.ps1 script instead of wait-for-rancher-desktop-backend.ps1
.github/workflows/graalvm.yml Updated to use the new config-rdctl.ps1 script instead of wait-for-rancher-desktop-backend.ps1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sandynz sandynz merged commit e17932b into apache:master Jan 5, 2026
23 checks passed
@linghengqian linghengqian deleted the fix-doc branch January 5, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants